lkml.org 
[lkml]   [2015]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] sched: add trace event for idle injection
On Thu, 19 Nov 2015 14:39:35 +0000
Javi Merino <javi.merino@arm.com> wrote:

> > +
>
> One minor nit: can you use key=value (i.e. "throttled=%d") instead for
> consistency with the rest of this file?
>
will do.
> Other than that, I know that Peter suggested an enum for the action,
> but wouldn't it be better to create an EVENT_CLASS and subclass the
> three actions from it? Something like:
I agree, it will be more readable in the trace.


thanks you


\
 
 \ /
  Last update: 2015-11-19 17:01    [W:0.108 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site