lkml.org 
[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V6 RESEND 2/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC
From
Date

Zabel,
On 2015/11/19 1:27, Philipp Zabel wrote:
> Am Freitag, den 30.10.2015, 11:19 +0800 schrieb Chen Feng:
>> Add reset driver for hi6220-hikey board,this driver supply deassert
>> of IP on hi6220 SoC.
>>
>> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> [...]
>> diff --git a/drivers/reset/hisilicon/Kconfig b/drivers/reset/hisilicon/Kconfig
>> new file mode 100644
>> index 0000000..26bf95a
>> --- /dev/null
>> +++ b/drivers/reset/hisilicon/Kconfig
>> @@ -0,0 +1,5 @@
>> +config COMMON_RESET_HI6220
>> + tristate "Hi6220 Reset Driver"
>> + depends on (ARCH_HISI && RESET_CONTROLLER)
>> + help
>> + Build the Hisilicon Hi6220 reset driver.
>
> Why is this configurable? Can't you just drop the Kconfig and use ...
>
>> diff --git a/drivers/reset/hisilicon/Makefile b/drivers/reset/hisilicon/Makefile
>> new file mode 100644
>> index 0000000..c932f86
>> --- /dev/null
>> +++ b/drivers/reset/hisilicon/Makefile
>> @@ -0,0 +1 @@
>> +obj-$(CONFIG_COMMON_RESET_HI6220) += hi6220_reset.o
>
> ... obj-$(CONFIG_ARCH_HISI) += hi6220_reset.o
>
> here?
>
Currently, the support SoC is hi6220 which is one of Kirin solution.

I can't use obj-$(CONFIG_ARCH_HISI) += hi6220_reset.o here.

Because,the hisilicon chip sets also have server chip(eg:D02,D03) and other solution.

The reset controller may be different.

> regards
> Philipp
>
>
>
> .
>



\
 
 \ /
  Last update: 2015-11-19 03:21    [W:0.074 / U:17.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site