lkml.org 
[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v6 15/19] arm64: ilp32: force IPC_64 in msgctl, shmctl, semctl
    Date
    Arnd Bergmann <arnd@arndb.de> writes:

    > On Wednesday 18 November 2015 00:16:55 Yury Norov wrote:
    >>
    >> +/* IPC_64 */
    >> +asmlinkage long ilp32_sys_msgctl(int first, int second, void __user *uptr)
    >> +{
    >> + return compat_sys_msgctl(first, second | IPC_64, uptr);
    >> +}
    >> +#define compat_sys_msgctl ilp32_sys_msgctl
    >> +
    >> +asmlinkage long ilp32_sys_shmctl(int first, int second, void __user *uptr)
    >> +{
    >> + return compat_sys_shmctl(first, second | IPC_64, uptr);
    >> +}
    >> +#define compat_sys_shmctl ilp32_sys_shmctl
    >> +
    >> +asmlinkage long ilp32_sys_semctl(int first, int second, int third, int arg)
    >> +{
    >> + return compat_sys_semctl(first, second, third | IPC_64, arg);
    >> +}
    >> +#define compat_sys_semctl ilp32_sys_semctl
    >>
    >
    > I wonder if this would be any simpler by changing compat_ipc_parse_version()

    This cries for a generic solution. Other archs migrating to separate
    ipc syscalls will want to avoid the whole IPC_64 business for them, even
    if they need to retain [compat_]ipc_parse_version for sys_ipc
    compatibility.

    Andreas.

    --
    Andreas Schwab, SUSE Labs, schwab@suse.de
    GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
    "And now for something completely different."


    \
     
     \ /
      Last update: 2015-11-18 09:41    [W:2.065 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site