[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] writeback: initialize m_dirty to avoid compile warning
On 11/18/2015 10:33 AM, Tejun Heo wrote:
> Hello,
> On Wed, Nov 18, 2015 at 10:27:32AM -0800, Shi, Yang wrote:
>>> This was the main reason the code was structured the way it is. If
>>> cgroup writeback is not enabled, any derefs of mdtc variables should
>>> trigger warnings. Ugh... I don't know. Compiler really should be
>>> able to tell this much.
>> Thanks for the explanation. It sounds like a compiler problem.
>> If you think it is still good to cease the compile warning, maybe we could
> If this is gonna be a problem with new gcc versions, I don't think we
> have any other options. :(
>> just assign it to an insane value as what Andrew suggested, maybe
>> 0xdeadbeef.
> I'd just keep it at zero. Whatever we do, the effect is gonna be
> difficult to track down - it's not gonna blow up in an obvious way.
> Can you please add a comment tho explaining that this is to work
> around compiler deficiency?


Other than this, in v2, I will just initialize m_dirty since compiler
just reports it is uninitialized.


> Thanks.

 \ /
  Last update: 2015-11-18 20:01    [W:0.046 / U:4.232 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site