[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc
On 11/18/2015 10:37 AM, Petr Mladek wrote:
> On Mon 2015-11-16 11:03:06, Chris J Arges wrote:
>> In cases of duplicate symbols, sympos will be used to disambiguate instead
>> of val. By default sympos will be 0, and patching will only succeed if
>> the symbol is unique. Specifying a positive value will ensure that
>> occurrence of the symbol in kallsyms for the patched object will be used
>> for patching if it is valid.
>> Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol
>> as they are no longer used.
>> >From the klp_reloc structure remove val, as it can be refactored as a
> ^
> Please, remove this extra '>'. I guess that you cut&pasted the
> comment from a mail reply ;-)
> Best Regards,
> Petr

I think that '>' was added in a subsequent reply. My patch doesn't have
that, and I'm guessing checkpatch would have warned me about that as well.
: )


 \ /
  Last update: 2015-11-18 18:01    [W:0.052 / U:39.228 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site