Messages in this thread Patch in this message | | | From | Petr Mladek <> | Subject | [PATCH v3 12/22] kthread: Use try_lock_kthread_work() in flush_kthread_work() | Date | Wed, 18 Nov 2015 14:25:17 +0100 |
| |
Remove code duplication and use the new try_lock_kthread_work() function in flush_kthread_work() as well.
Signed-off-by: Petr Mladek <pmladek@suse.com> --- kernel/kthread.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/kernel/kthread.c b/kernel/kthread.c index dbd090466e2a..f7caaaca5825 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -933,16 +933,12 @@ void flush_kthread_work(struct kthread_work *work) struct kthread_worker *worker; bool noop = false; -retry: - worker = work->worker; - if (!worker) + local_irq_disable(); + if (!try_lock_kthread_work(work)) { + local_irq_enable(); return; - - spin_lock_irq(&worker->lock); - if (work->worker != worker) { - spin_unlock_irq(&worker->lock); - goto retry; } + worker = work->worker; if (!list_empty(&work->node)) insert_kthread_work(worker, &fwork.work, work->node.next); -- 1.8.5.6
| |