Messages in this thread | | | Date | Wed, 18 Nov 2015 12:28:46 +0100 | From | Borislav Petkov <> | Subject | Re: [RFC PATCH 1/3] x86/cpu: Unify CPU family, model, stepping calculation |
| |
On Wed, Nov 18, 2015 at 12:10:08PM +0100, Paolo Bonzini wrote: > On 14/11/2015 11:37, Borislav Petkov wrote: > > vendor = x86_vendor(); > > - family = x86_family(); > > + family = x86_family_cpuid(); > > What about renaming x86_vendor() so that this looks like > > - vendor = x86_vendor(); > - family = x86_family(); > + vendor = x86_cpuid_vendor(); > + family = x86_cpuid_family();
The idea is that x86_family_cpuid() gives the family *after* having executed CPUID while x86_family() only computes the family from a supplied CPUID_1_EAX. I.e., the last saves us the CPUID call.
Hmm, maybe I should make that more clear ...
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |