lkml.org 
[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 07/10] KVM: x86: MMU: Encapsulate the type of rmap-chain head in a new struct
From
Date


On 18/11/2015 04:21, Xiao Guangrong wrote:
>
>
> On 11/12/2015 07:55 PM, Takuya Yoshikawa wrote:
>> @@ -1720,7 +1724,7 @@ static struct kvm_mmu_page
>> *kvm_mmu_alloc_page(struct kvm_vcpu *vcpu,
>> * this feature. See the comments in kvm_zap_obsolete_pages().
>> */
>> list_add(&sp->link, &vcpu->kvm->arch.active_mmu_pages);
>> - sp->parent_ptes = 0;
>> + sp->parent_ptes.val = 0;
>
> The sp is allocated from kmem_cache_zalloc() so explicitly initialize it
> to zero is not needed.

Right, but it should be a separate patch.

Takuya, since you are going to send another version of this series, can
you also:

1) move this patch either to the beginning or to the end

2) include "KVM: x86: always set accessed bit in shadow PTEs", also near
the beginning of the series?

Thanks!

Paolo


\
 
 \ /
  Last update: 2015-11-18 10:41    [W:0.079 / U:1.344 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site