lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 02/10] KVM: x86: MMU: Add helper function to clear a bit in unsync child bitmap
From
Date


On 11/12/2015 07:50 PM, Takuya Yoshikawa wrote:
> + if (!ret) {
> + clear_unsync_child_bit(sp, i);
> + continue;
> + } else if (ret > 0) {
> nr_unsync_leaf += ret;

Just a single line here, braces are unnecessary.

> - else
> + } else
> return ret;
> } else if (child->unsync) {
> nr_unsync_leaf++;
> if (mmu_pages_add(pvec, child, i))
> return -ENOSPC;
> } else
> - goto clear_child_bitmap;
> -
> - continue;
> -
> -clear_child_bitmap:
> - __clear_bit(i, sp->unsync_child_bitmap);
> - sp->unsync_children--;
> - WARN_ON((int)sp->unsync_children < 0);
> + clear_unsync_child_bit(sp, i);
> }


\
 
 \ /
  Last update: 2015-11-18 04:21    [W:0.137 / U:33.116 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site