Messages in this thread | | | Date | Tue, 17 Nov 2015 16:22:26 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH 2/5] kernfs: implement kernfs_walk_and_get() |
| |
On Tue, Nov 17, 2015 at 04:20:40PM -0500, David Miller wrote: > From: Tejun Heo <tj@kernel.org> > Date: Tue, 17 Nov 2015 14:40:37 -0500 > > > + static char path_buf[PATH_MAX]; /* protected by kernfs_mutex */ > > + int len = strlen(path); > ... > > + if (len >= PATH_MAX) > > + return NULL; > > + > > + memcpy(path_buf, path, len + 1); > > static char path_buf[PATH_MAX]; /* protected by kernfs_mutex */ > int len = strlcpy(path_buf, path, PATH_MAX); > ... > if (len >= PATH_MAX) > return NULL;
That's a lot better. Will update.
Thanks.
-- tejun
| |