lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] scsi_lib: Delete unnecessary checks before two function calls
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 17 Nov 2015 09:00:31 +0100

    The functions kmem_cache_destroy() and mempool_destroy() test whether
    their argument is NULL and then return immediately.
    Thus the tests around their calls are not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/scsi/scsi_lib.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
    index dd8ad2a..13973a3 100644
    --- a/drivers/scsi/scsi_lib.c
    +++ b/drivers/scsi/scsi_lib.c
    @@ -2298,10 +2298,8 @@ int __init scsi_init_queue(void)
    cleanup_sdb:
    for (i = 0; i < SG_MEMPOOL_NR; i++) {
    struct scsi_host_sg_pool *sgp = scsi_sg_pools + i;
    - if (sgp->pool)
    - mempool_destroy(sgp->pool);
    - if (sgp->slab)
    - kmem_cache_destroy(sgp->slab);
    + mempool_destroy(sgp->pool);
    + kmem_cache_destroy(sgp->slab);
    }
    kmem_cache_destroy(scsi_sdb_cache);

    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-17 09:21    [W:4.019 / U:1.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site