lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: net-scm: Delete an unnecessary check before the function call "kfree"
    On 11/17/2015 07:05 PM, SF Markus Elfring wrote:
    >> Eric already mentioned that in some situations where it's critical,
    >> it actually slows down the code, i.e. you'll have an extra
    >> function call to get there and inside kfree() / kfree_skb() / etc,
    >> the test is actually marked as unlikely().
    >
    > How do you think about to add similar annotations to any more
    > source code places?

    You mean this likely() annotation of yours? It doesn't make any sense
    to me to place it there, and since you've spend the second thinking
    about it when adding it to the diff, you should have already realized
    that your code was buggy ...


    \
     
     \ /
      Last update: 2015-11-17 20:01    [W:4.061 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site