Messages in this thread | | | Date | Tue, 17 Nov 2015 21:48:48 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 3/4] crypto-ixp4xx: Reduce assignment for a variable in init_ixp_crypto() |
| |
On Sun, Nov 15, 2015 at 07:52:22PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 15 Nov 2015 19:06:44 +0100 > > The variable "ret" was set more often than necessary by the > init_ixp_crypto() function. > > * Omit its initialisation at the beginning. > > * Use an error return code in two cases directly. > > * Improve compliance with the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Again I don't see how this is making the code better so nack. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |