Messages in this thread | | | Date | Tue, 17 Nov 2015 11:17:40 +0800 | From | Hanjun Guo <> | Subject | Re: [PATCH] PCI: hisi: fix deferred probing |
| |
On 11/13/2015 03:29 PM, Zhou Wang wrote: > On 2015/11/12 20:21, Arnd Bergmann wrote: >> The hisi_pcie_probe function is incorrectly marked as __init, as Kconfig >> tells us: >> >> WARNING: drivers/pci/host/built-in.o(.data+0x7780): Section mismatch in reference from the variable hisi_pcie_driver to the function .init.text:hisi_pcie_probe() >> >> If the probe for this device gets deferred past the point where __init >> functions are removed, or the device is unbound and then reattached to >> the driver, we branch into uninitialized memory, which is bad. >> >> This removes the __init annotation. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> > > Hi Arnd, > > Many thanks, it looks good to me. so > Acked-by: Zhou Wang <wangzhou1@hisilicon.com>
I found this problem too and prepared a patch for it, but I noticed that Arnd already fixed it :)
Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
Thanks Hanjun
| |