lkml.org 
[lkml]   [2015]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] net: dsa: Delete an unnecessary check before the function call "put_device"
    From

    I'm starting to grow quite weary of these "unnecessary check" changes.

    Sometimes it is better to have them, either because the path is a hot
    path or some atomic sequence is involved.

    But there is never harm in them being there.

    All of this is a matter of taste, of course. But one thing I know for
    sure, it is undisputable that there are much more important things to
    work on than this kind of stuff...

    So I'm not applying these changes any more and directing my time and
    effort to reviewing and applying patches that fix bugs, really
    restructure the code in useful ways that increase maintainability over
    the long time, and add interesting new features.

    These patches do none of the above.


    \
     
     \ /
      Last update: 2015-11-16 21:41    [W:4.020 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site