lkml.org 
[lkml]   [2015]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] GPU-DRM-TTM: Delete an unnecessary check before the function call "ttm_tt_destroy"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 16 Nov 2015 15:40:58 +0100

    The ttm_tt_destroy() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/ttm/ttm_bo.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
    index 745e996..d6736e6 100644
    --- a/drivers/gpu/drm/ttm/ttm_bo.c
    +++ b/drivers/gpu/drm/ttm/ttm_bo.c
    @@ -147,8 +147,7 @@ static void ttm_bo_release_list(struct kref *list_kref)
    BUG_ON(!list_empty(&bo->lru));
    BUG_ON(!list_empty(&bo->ddestroy));

    - if (bo->ttm)
    - ttm_tt_destroy(bo->ttm);
    + ttm_tt_destroy(bo->ttm);
    atomic_dec(&bo->glob->bo_count);
    if (bo->resv == &bo->ttm_resv)
    reservation_object_fini(&bo->ttm_resv);
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-16 16:01    [W:2.265 / U:4.600 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site