lkml.org 
[lkml]   [2015]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] SCSI-zfcp: Delete unnecessary checks before the function call "mempool_destroy"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 16 Nov 2015 14:19:03 +0100

    The mempool_destroy() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the calls is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/s390/scsi/zfcp_aux.c | 21 +++++++--------------
    1 file changed, 7 insertions(+), 14 deletions(-)

    diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c
    index c00ac46..abc9c93 100644
    --- a/drivers/s390/scsi/zfcp_aux.c
    +++ b/drivers/s390/scsi/zfcp_aux.c
    @@ -248,20 +248,13 @@ static int zfcp_allocate_low_mem_buffers(struct zfcp_adapter *adapter)

    static void zfcp_free_low_mem_buffers(struct zfcp_adapter *adapter)
    {
    - if (adapter->pool.erp_req)
    - mempool_destroy(adapter->pool.erp_req);
    - if (adapter->pool.scsi_req)
    - mempool_destroy(adapter->pool.scsi_req);
    - if (adapter->pool.scsi_abort)
    - mempool_destroy(adapter->pool.scsi_abort);
    - if (adapter->pool.qtcb_pool)
    - mempool_destroy(adapter->pool.qtcb_pool);
    - if (adapter->pool.status_read_req)
    - mempool_destroy(adapter->pool.status_read_req);
    - if (adapter->pool.sr_data)
    - mempool_destroy(adapter->pool.sr_data);
    - if (adapter->pool.gid_pn)
    - mempool_destroy(adapter->pool.gid_pn);
    + mempool_destroy(adapter->pool.erp_req);
    + mempool_destroy(adapter->pool.scsi_req);
    + mempool_destroy(adapter->pool.scsi_abort);
    + mempool_destroy(adapter->pool.qtcb_pool);
    + mempool_destroy(adapter->pool.status_read_req);
    + mempool_destroy(adapter->pool.sr_data);
    + mempool_destroy(adapter->pool.gid_pn);
    }

    /**
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-16 14:41    [W:3.709 / U:6.144 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site