Messages in this thread | | | Date | Mon, 16 Nov 2015 13:39:27 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH 1/7] ipc/shm: is_file_shm_hugepages can be boolean |
| |
On Mon 16-11-15 14:51:20, Yaowei Bai wrote: > This patch makes is_file_shm_hugepages return bool to improve > readability due to this particular function only using either > one or zero as its return value.
yes it makes sense here.
> No functional change. > > Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> --- > include/linux/shm.h | 6 +++--- > ipc/shm.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/shm.h b/include/linux/shm.h > index 6fb8016..04e8818 100644 > --- a/include/linux/shm.h > +++ b/include/linux/shm.h > @@ -52,7 +52,7 @@ struct sysv_shm { > > long do_shmat(int shmid, char __user *shmaddr, int shmflg, unsigned long *addr, > unsigned long shmlba); > -int is_file_shm_hugepages(struct file *file); > +bool is_file_shm_hugepages(struct file *file); > void exit_shm(struct task_struct *task); > #define shm_init_task(task) INIT_LIST_HEAD(&(task)->sysvshm.shm_clist) > #else > @@ -66,9 +66,9 @@ static inline long do_shmat(int shmid, char __user *shmaddr, > { > return -ENOSYS; > } > -static inline int is_file_shm_hugepages(struct file *file) > +static inline bool is_file_shm_hugepages(struct file *file) > { > - return 0; > + return false; > } > static inline void exit_shm(struct task_struct *task) > { > diff --git a/ipc/shm.c b/ipc/shm.c > index 4178727..ed3027d 100644 > --- a/ipc/shm.c > +++ b/ipc/shm.c > @@ -459,7 +459,7 @@ static const struct file_operations shm_file_operations_huge = { > .fallocate = shm_fallocate, > }; > > -int is_file_shm_hugepages(struct file *file) > +bool is_file_shm_hugepages(struct file *file) > { > return file->f_op == &shm_file_operations_huge; > } > -- > 1.9.1 > >
-- Michal Hocko SUSE Labs
| |