lkml.org 
[lkml]   [2015]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] ixp4xx_hss: Delete an unnecessary check before the function call "dma_pool_destroy"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 16 Nov 2015 13:30:37 +0100

    The dma_pool_destroy() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/wan/ixp4xx_hss.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
    index e7bbdb7..0d2593a 100644
    --- a/drivers/net/wan/ixp4xx_hss.c
    +++ b/drivers/net/wan/ixp4xx_hss.c
    @@ -1037,7 +1037,7 @@ static void destroy_hdlc_queues(struct port *port)
    port->desc_tab = NULL;
    }

    - if (!ports_open && dma_pool) {
    + if (!ports_open) {
    dma_pool_destroy(dma_pool);
    dma_pool = NULL;
    }
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-16 14:01    [W:3.795 / U:10.836 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site