lkml.org 
[lkml]   [2015]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] rtlwifi: Delete unnecessary checks before the function call "kfree_skb"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 16 Nov 2015 13:12:25 +0100

    The kfree_skb() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the calls is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/wireless/realtek/rtlwifi/core.c | 3 +--
    drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c | 4 +---
    2 files changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
    index c925a4d..4ae421e 100644
    --- a/drivers/net/wireless/realtek/rtlwifi/core.c
    +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
    @@ -1833,8 +1833,7 @@ bool rtl_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)

    spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
    pskb = __skb_dequeue(&ring->queue);
    - if (pskb)
    - kfree_skb(pskb);
    + kfree_skb(pskb);

    /*this is wrong, fill_tx_cmddesc needs update*/
    pdesc = &ring->desc[0];
    diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c
    index a2f5e89..6e51862 100644
    --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c
    +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c
    @@ -318,9 +318,7 @@ bool rtl8723_cmd_send_packet(struct ieee80211_hw *hw,
    ring = &rtlpci->tx_ring[BEACON_QUEUE];

    pskb = __skb_dequeue(&ring->queue);
    - if (pskb)
    - kfree_skb(pskb);
    -
    + kfree_skb(pskb);
    spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);

    pdesc = &ring->desc[0];
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-16 13:41    [W:3.593 / U:2.648 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site