lkml.org 
[lkml]   [2015]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] cxgb3: Delete unnecessary checks before the function call "kfree_skb"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 16 Nov 2015 12:46:41 +0100

    The kfree_skb() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the calls is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 3 +--
    drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 3 +--
    2 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
    index 8f7aa53a..89f193b 100644
    --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
    +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
    @@ -3401,8 +3401,7 @@ static void remove_one(struct pci_dev *pdev)
    free_netdev(adapter->port[i]);

    iounmap(adapter->regs);
    - if (adapter->nofail_skb)
    - kfree_skb(adapter->nofail_skb);
    + kfree_skb(adapter->nofail_skb);
    kfree(adapter);
    pci_release_regions(pdev);
    pci_disable_device(pdev);
    diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c
    index 76684dc..9a77339 100644
    --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c
    +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c
    @@ -1323,8 +1323,7 @@ void cxgb3_offload_deactivate(struct adapter *adapter)
    rcu_read_unlock();
    RCU_INIT_POINTER(tdev->l2opt, NULL);
    call_rcu(&d->rcu_head, clean_l2_data);
    - if (t->nofail_skb)
    - kfree_skb(t->nofail_skb);
    + kfree_skb(t->nofail_skb);
    kfree(t);
    }

    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-16 13:21    [W:4.017 / U:4.016 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site