lkml.org 
[lkml]   [2015]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] ixp4xx_eth: Delete an unnecessary check before the function call "dma_pool_destroy"
From
Date
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 16 Nov 2015 12:23:23 +0100

The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
index 5138407..6705951 100644
--- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
+++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
@@ -1192,7 +1192,7 @@ static void destroy_queues(struct port *port)
port->desc_tab = NULL;
}

- if (!ports_open && dma_pool) {
+ if (!ports_open) {
dma_pool_destroy(dma_pool);
dma_pool = NULL;
}
--
2.6.2


\
 
 \ /
  Last update: 2015-11-16 12:41    [W:1.821 / U:2.048 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site