lkml.org 
[lkml]   [2015]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] WiMAX-i2400m: Delete an unnecessary check before the function call "kfree_skb"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 16 Nov 2015 11:17:55 +0100

    The kfree_skb() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/wimax/i2400m/control.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wimax/i2400m/control.c b/drivers/net/wimax/i2400m/control.c
    index 4c41790..4de22b7 100644
    --- a/drivers/net/wimax/i2400m/control.c
    +++ b/drivers/net/wimax/i2400m/control.c
    @@ -644,7 +644,7 @@ void i2400m_msg_to_dev_cancel_wait(struct i2400m *i2400m, int code)

    spin_lock_irqsave(&i2400m->rx_lock, flags);
    ack_skb = i2400m->ack_skb;
    - if (ack_skb && !IS_ERR(ack_skb))
    + if (!IS_ERR(ack_skb))
    kfree_skb(ack_skb);
    i2400m->ack_skb = ERR_PTR(code);
    spin_unlock_irqrestore(&i2400m->rx_lock, flags);
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-16 11:41    [W:4.013 / U:12.484 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site