| Subject | Re: [PATCH 2/9] IB: add a proper completion queue abstraction | From | Sagi Grimberg <> | Date | Sun, 15 Nov 2015 11:40:02 +0200 |
| |
> +/** > + * ib_process_direct_cq - process a CQ in caller context > + * @cq: CQ to process > + * > + * This function is used to process all outstanding CQ entries on a > + * %IB_POLL_DIRECT CQ. It does not offload CQ processing to a different > + * context and does not ask from completion interrupts from the HCA. > + */ > +void ib_process_cq_direct(struct ib_cq *cq) > +{ > + WARN_ON_ONCE(cq->poll_ctx != IB_POLL_DIRECT); > + > + __ib_process_cq(cq, INT_MAX); > +}
I doubt INT_MAX is useful as a budget in any use-case. it can easily hog the CPU. If the consumer is given access to poll a CQ, it must be able to provide some way to budget it. Why not expose a budget argument to the consumer?
|