Messages in this thread | | | Subject | Re: [PATCH -next] serial: etraxfs-uart: Fix crash | From | Guenter Roeck <> | Date | Sun, 15 Nov 2015 16:42:40 -0800 |
| |
On 11/15/2015 03:54 PM, Niklas Cassel wrote: > I think that Guenter's patch should be merged asap. > Right now the bug it fixes stops us from boot testing in qemu. >
I'll send out a build (failure) report after -rc1 is out. Maybe that will create enough visibility to get the patch accepted (or officially Nacked).
Guenter
> For the broken mctrl irq handling part, when Uwe > has converted mxs-auart to use the generic irq init, > I can do the same for etraxfs + make sure that it gets tested > properly on real hardware. > > On 11/02/2015 10:29 PM, Uwe Kleine-König wrote: >> Helo Niklas, >> >> On Mon, Nov 02, 2015 at 10:13:25PM +0100, Niklas Cassel wrote: >>> On 11/02/2015 08:37 AM, Uwe Kleine-König wrote: >>>>> The function call in the etraxfs-uart driver was not renamed, >>>>> possibly due to interference with commit 7b9c5162c182 ("serial: >>>>> etraxfs-uart: use mctrl_gpio helpers for handling modem signals"). >>>> Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt handling >>>> is missing. >>> The only drivers including serial_mctrl_gpio.h is atmel_serial.c, >>> clps711x.c, mxs-auart.c and etraxfs-uart.c >>> >>> etraxfs commit >>> 7b9c5162c182 ("serial: etraxfs-uart: use mctrl_gpio helpers for handling modem signals") >>> is heavily influenced by >>> 62b0a1b3e759 ("serial: clps711x: Use mctrl_gpio helpers for handling modem signals") >>> >>> a driver which also appears to lack mctrl irq setup/handling. >>> >>> >>> Uwe, are you going to convert all serial drivers that includes serial_mctrl_gpio.h to >>> use the new mctrl_gpio_init? (which also sets up irqs) >> That is the plan. For drivers like mxs-auart (that do irq handling) this >> is just simplification. When the irq handling is missing converting to >> the new mctrl_gpio_init might introduce regressions because it does >> request_irq which might fail. >> >>> Since mctrl gpios are optional in the device tree, I guess mctrl_gpio_init handles if >>> they are missing. So even if etraxfs-uart.c currently lacks mctrl irq setup/handling, >>> if we migrate it to use the new mctrl_gpio_init, we will get this automatically? >> Right, if there are no gpios specified (new and old) mctrl_gpio is a >> nop. >> >> Best regards >> Uwe >> > >
| |