Messages in this thread Patch in this message | | | Subject | [PATCH] NFC-nci: Delete unnecessary checks before the function call "kfree_skb" | From | SF Markus Elfring <> | Date | Sat, 14 Nov 2015 22:50:31 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 14 Nov 2015 22:42:48 +0100
The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- net/nfc/nci/uart.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/net/nfc/nci/uart.c b/net/nfc/nci/uart.c index 21d8875..106ecc1 100644 --- a/net/nfc/nci/uart.c +++ b/net/nfc/nci/uart.c @@ -199,11 +199,8 @@ static void nci_uart_tty_close(struct tty_struct *tty) if (!nu) return; - if (nu->tx_skb) - kfree_skb(nu->tx_skb); - if (nu->rx_skb) - kfree_skb(nu->rx_skb); - + kfree_skb(nu->tx_skb); + kfree_skb(nu->rx_skb); skb_queue_purge(&nu->tx_q); nu->ops.close(nu); -- 2.6.2
| |