lkml.org 
[lkml]   [2015]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Xen-devel] [PATCH v4 2/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64
    Hi Stefano,

    On 12/11/15 17:30, Stefano Stabellini wrote:
    > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    >
    > ---
    >
    > Changes in v2:
    > - rename dom0_op to platform_op
    > ---
    > arch/arm/include/asm/xen/hypercall.h | 2 ++
    > arch/arm/xen/enlighten.c | 1 +
    > arch/arm/xen/hypercall.S | 1 +
    > arch/arm64/xen/hypercall.S | 1 +
    > 4 files changed, 5 insertions(+)
    >
    > diff --git a/arch/arm/include/asm/xen/hypercall.h b/arch/arm/include/asm/xen/hypercall.h
    > index 712b50e..c3e00d0 100644
    > --- a/arch/arm/include/asm/xen/hypercall.h
    > +++ b/arch/arm/include/asm/xen/hypercall.h
    > @@ -35,6 +35,7 @@
    >
    > #include <xen/interface/xen.h>
    > #include <xen/interface/sched.h>
    > +#include <xen/interface/platform.h>
    >
    > long privcmd_call(unsigned call, unsigned long a1,
    > unsigned long a2, unsigned long a3,
    > @@ -49,6 +50,7 @@ int HYPERVISOR_memory_op(unsigned int cmd, void *arg);
    > int HYPERVISOR_physdev_op(int cmd, void *arg);
    > int HYPERVISOR_vcpu_op(int cmd, int vcpuid, void *extra_args);
    > int HYPERVISOR_tmem_op(void *arg);
    > +int HYPERVISOR_platform_op(void *arg);

    int HYPERVISOR_platform_op(struct xen_platform_op *platform_op) to allow
    compiler type checking and match the x86 version.

    Also, the implementation of the helper differ from x86. On x86, the
    helper takes care of setting the interface_version while here you
    request the caller to do it.

    It's better if we have similar requirement across the architecture as
    this helpers may be called from common code.

    > int HYPERVISOR_multicall(struct multicall_entry *calls, uint32_t nr);
    >
    > static inline int

    Regards,

    --
    Julien Grall


    \
     
     \ /
      Last update: 2015-11-13 15:01    [W:4.032 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site