lkml.org 
[lkml]   [2015]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 024/155] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS
    Date
    3.19.8-ckt10 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: =?UTF-8?q?Dirk=20M=C3=BCller?= <dmueller@suse.com>

    commit d2922422c48df93f3edff7d872ee4f3191fefb08 upstream.

    The cpu feature flags are not ever going to change, so warning
    everytime can cause a lot of kernel log spam
    (in our case more than 10GB/hour).

    The warning seems to only occur when nested virtualization is
    enabled, so it's probably triggered by a KVM bug. This is a
    sensible and safe change anyway, and the KVM bug fix might not
    be suitable for stable releases anyway.

    Signed-off-by: Dirk Mueller <dmueller@suse.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    arch/x86/kvm/svm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
    index dd68f32..fe5d87e 100644
    --- a/arch/x86/kvm/svm.c
    +++ b/arch/x86/kvm/svm.c
    @@ -512,7 +512,7 @@ static void skip_emulated_instruction(struct kvm_vcpu *vcpu)
    struct vcpu_svm *svm = to_svm(vcpu);

    if (svm->vmcb->control.next_rip != 0) {
    - WARN_ON(!static_cpu_has(X86_FEATURE_NRIPS));
    + WARN_ON_ONCE(!static_cpu_has(X86_FEATURE_NRIPS));
    svm->next_rip = svm->vmcb->control.next_rip;
    }

    --
    1.9.1


    \
     
     \ /
      Last update: 2015-11-13 01:21    [W:3.448 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site