Messages in this thread | | | Date | Thu, 12 Nov 2015 19:42:19 +0100 | Subject | Re: [PATCH] lightnvm: change max_phys_sect to ushort | From | Geert Uytterhoeven <> |
| |
On Thu, Nov 12, 2015 at 7:35 PM, Matias Bjørling <m@bjorling.me> wrote: > The max_phys_sect variable is defined as a char. We do a boundary check > to maximally allow 256 physical page descriptors per command. As we are > not indexing from zero. This expression is always in false. Bump the > max_phys_sect to an unsigned short to support the range check.
unsigned int?
> > Signed-off-by: Matias Bjørling <m@bjorling.me> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > include/linux/lightnvm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h > index 69c9057..4b1cd3d 100644 > --- a/include/linux/lightnvm.h > +++ b/include/linux/lightnvm.h > @@ -220,7 +220,7 @@ struct nvm_dev_ops { > nvm_dev_dma_alloc_fn *dev_dma_alloc; > nvm_dev_dma_free_fn *dev_dma_free; > > - uint8_t max_phys_sect; > + unsigned int max_phys_sect;
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |