lkml.org 
[lkml]   [2015]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] comedi: cb_pcidda: Fix coding style - use BIT macro
From
Date
On 11/11/15 16:27, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith Thangavel <ranjithece24@gmail.com>
> ---
> drivers/staging/comedi/drivers/cb_pcidda.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidda.c b/drivers/staging/comedi/drivers/cb_pcidda.c
> index b00a36a..ccb37d1 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidda.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidda.c
> @@ -51,13 +51,13 @@
>
> /* DAC registers */
> #define CB_DDA_DA_CTRL_REG 0x00 /* D/A Control Register */
> -#define CB_DDA_DA_CTRL_SU (1 << 0) /* Simultaneous update */
> -#define CB_DDA_DA_CTRL_EN (1 << 1) /* Enable specified DAC */
> +#define CB_DDA_DA_CTRL_SU BIT(0) /* Simultaneous update */
> +#define CB_DDA_DA_CTRL_EN BIT(1) /* Enable specified DAC */
> #define CB_DDA_DA_CTRL_DAC(x) ((x) << 2) /* Specify DAC channel */
> #define CB_DDA_DA_CTRL_RANGE2V5 (0 << 6) /* 2.5V range */
> #define CB_DDA_DA_CTRL_RANGE5V (2 << 6) /* 5V range */
> #define CB_DDA_DA_CTRL_RANGE10V (3 << 6) /* 10V range */
> -#define CB_DDA_DA_CTRL_UNIP (1 << 8) /* Unipolar range */
> +#define CB_DDA_DA_CTRL_UNIP BIT(8) /* Unipolar range */
>
> #define DACALIBRATION1 4 /* D/A CALIBRATION REGISTER 1 */
> /* write bits */
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-


\
 
 \ /
  Last update: 2015-11-12 19:21    [W:0.044 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site