lkml.org 
[lkml]   [2015]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2] mm: fix kernel crash in khugepaged thread
From
Date
Ok
i will send a V3 patch.
> On Nov 5, 2015, at 16:50, Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
> On Thu, Nov 05, 2015 at 09:12:34AM +0100, Vlastimil Babka wrote:
>> On 10/29/2015 01:35 AM, Kirill A. Shutemov wrote:
>>>> @@ -2605,9 +2603,9 @@ out_unmap:
>>>> /* collapse_huge_page will return with the mmap_sem released */
>>>> collapse_huge_page(mm, address, hpage, vma, node);
>>>> }
>>>> -out:
>>>> - trace_mm_khugepaged_scan_pmd(mm, page_to_pfn(page), writable, referenced,
>>>> - none_or_zero, result, unmapped);
>>>> + trace_mm_khugepaged_scan_pmd(mm, pte_present(pteval) ?
>>>> + pte_pfn(pteval) : -1, writable, referenced,
>>>> + none_or_zero, result, unmapped);
>>>
>>> maybe passing down pte instead of pfn?
>>
>> Maybe just pass the page, and have tracepoint's fast assign check for !NULL and
>> do page_to_pfn itself? That way the complexity and overhead is only in the
>> tracepoint and when enabled.
>
> Agreed.
>
> --
> Kirill A. Shutemov



\
 
 \ /
  Last update: 2015-11-12 08:21    [W:0.077 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site