Messages in this thread | | | Date | Thu, 12 Nov 2015 13:16:13 +0100 | From | Borislav Petkov <> | Subject | Re: Shut up unhandled MSR warnings |
| |
On Thu, Nov 12, 2015 at 11:59:58AM +0100, Borislav Petkov wrote: > On Thu, Nov 12, 2015 at 11:33:33AM +0100, Paolo Bonzini wrote: > > Yes, see guest_cpuid_has_* for an example of reading the CPUID values. > > > > But if it's defined for _all_ models starting at family 21, we can just > > do it unconditionally. > > The thing is, those bits are Reserved again on the next family 22. Lemme > take a look at guest_cpuid_has_* and see how ugly it gets.
Ok, I see there's guest_cpuid_is_amd() but I'd need also family and model.
How about adding also
guest_cpuid_family(), guest_cpuid_model(), guest_cpuid_stepping()? Those could be quite useful in other contexts maybe.
Or, I can do a single function which simply returns CPUID_1_EAX of the guest vcpu and caller can then pick stuff apart...
Thoughts?
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |