Messages in this thread | | | Date | Thu, 12 Nov 2015 11:38:10 +0100 | Subject | Re: [PATCH v4 2/3] mtd: nand: Add support for Arasan Nand Flash Controller | From | Geert Uytterhoeven <> |
| |
On Thu, Nov 12, 2015 at 11:32 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Thu, 2015-11-12 at 10:18 +0530, punnaiah choudary kalluri wrote: >> On Mon, Nov 9, 2015 at 7:20 PM, Andy Shevchenko >> <andriy.shevchenko@linux.intel.com> wrote: >> > On Thu, 2015-11-05 at 08:19 +0530, Punnaiah Choudary Kalluri wrote: >> > > Added the basic driver for Arasan Nand Flash Controller used in >> > > Zynq UltraScale+ MPSoC. It supports only Hw Ecc and upto 24bit >> > > correction. >> > > >> > >> > > +config MTD_NAND_ARASAN >> > > + tristate "Support for Arasan Nand Flash controller" >> > > + depends on MTD_NAND >> > >> > This looks useless since you can't see the item without MTD_NAND is >> > chosen. >> > >> > > + help >> > > + Enables the driver for the Arasan Nand Flash controller >> > > on >> > > + Zynq UltraScale+ MPSoC. >> > > + >> > > endif # MTD_NAND >> > > >> > >> > +obj-$(CONFIG_MTD_NAND_ARASAN) += arasan_nfc.o >> > >> > "nfc" part a bit ambiguous since NFC might be Near Field >> > Communication. >> >> This driver is under mtd/nand so, there is no point of confusion and >> in this context nfc is nand flash controller. > > Imagine that at some point arasan (whatever) releases NFC chip, and > someone puts the driver under corresponding folder but with the same > file name (and driver name). Do you see a problem? I see two: > - if you built-in both how you supply command line parameters? > - some platform code may do request_module() or > platform_driver_register() with the name you provided as DRIVER_NAME.
#3: Module filenames must be unique, too. "modprobe arasan_nfc.ko" won't know which module to load.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |