lkml.org 
[lkml]   [2015]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.
    From
    On Thu, Nov 12, 2015 at 11:07 AM, dave penkler <dpenkler@gmail.com> wrote:
    > Thanks for your comments, I will resubmit taking into account all
    > suggestions.
    >
    >> > - redundant parens

    Example 1.
    + (atomic_read(&data->iin_data_valid) != 0),

    >> > - pieces of code takes whole line when they are quite fit tail of
    >> > previous one.
    >> >
    >
    >
    > I have endeavoured to follow the coding style of the original driver and
    > stick to the kernel coding-style guidelines.
    > Please point to the specific locations where I have failed to do so.

    Example 1.
    + dev_err(dev, "control status returned %x\n",
    + buffer[0]);

    example 2.
    + USBTMC_TIMEOUT
    + );


    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2015-11-12 11:01    [W:2.227 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site