Messages in this thread | | | Date | Thu, 12 Nov 2015 11:41:37 +0200 | Subject | Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation. | From | Andy Shevchenko <> |
| |
On Thu, Nov 12, 2015 at 11:07 AM, dave penkler <dpenkler@gmail.com> wrote: > Thanks for your comments, I will resubmit taking into account all > suggestions. > >> > - redundant parens
Example 1. + (atomic_read(&data->iin_data_valid) != 0),
>> > - pieces of code takes whole line when they are quite fit tail of >> > previous one. >> > > > > I have endeavoured to follow the coding style of the original driver and > stick to the kernel coding-style guidelines. > Please point to the specific locations where I have failed to do so.
Example 1. + dev_err(dev, "control status returned %x\n", + buffer[0]);
example 2. + USBTMC_TIMEOUT + );
-- With Best Regards, Andy Shevchenko
| |