Messages in this thread | | | Date | Wed, 11 Nov 2015 15:46:07 -0800 | From | Brian Norris <> | Subject | Re: [PATCH v2 06/11] mtd: nand: drop unnecessary partition parser data |
| |
On Mon, Nov 02, 2015 at 01:00:01PM -0800, Brian Norris wrote: > On Sun, Nov 01, 2015 at 11:32:37PM +0100, Boris Brezillon wrote: > > On Fri, 30 Oct 2015 20:33:25 -0700 > > Brian Norris <computersforpeace@gmail.com> wrote: > > > [...] > > > diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c > > > index dcb1f7f4873f..850546dc98c8 100644 > > > --- a/drivers/mtd/nand/fsl_elbc_nand.c > > > +++ b/drivers/mtd/nand/fsl_elbc_nand.c > > > @@ -748,6 +748,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv) > > > /* Fill in fsl_elbc_mtd structure */ > > > priv->mtd.priv = chip; > > > priv->mtd.dev.parent = priv->dev; > > > + chip->flash_node = priv->dev->of_node; > > > > Shouldn't we use the nand_set_flash_node() helper here? Here is a diff replacing > > all 'chip->flash_node =' occurrences by nand_set_flash_node(): > > Hmm, I don't know why I overlooked those. I think maybe I did the > initial replacement before this patch and forgot to do the same > replacement on my subsequent work. I guess that's what happens when I > rebase/rework too much... > > Thanks for the diff. I'll probably squash it into v3 if/when that comes.
Pushed my patch 6 + your diff to l2-mtd.git/next. Thanks!
| |