lkml.org 
[lkml]   [2015]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.
From
On Wed, Nov 11, 2015 at 9:48 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 11/11/2015 10:03 PM, Andy Shevchenko wrote:

>> Won't comment precisely by line, but common nitpicks about style:
>> - added empty lines where no need
>> - redundant parens
>> - pieces of code takes whole line when they are quite fit tail of
>> previous one.
>>
>> And why malloc for 8 bytes?

> It's a good tone to skip the parts you're not commenting on, so others
> wouldn't have to scroll in vain.

Isn't obvious from my comment that no scroll is needed?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2015-11-11 21:01    [W:0.144 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site