lkml.org 
[lkml]   [2015]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v2 1/4] drm: arm: Add DT bindings documentation for HDLCD driver.
    On Wed, Nov 11, 2015 at 04:06:47PM +0000, Liviu Dudau wrote:
    > Cc: Rob Herring <robh+dt@kernel.org>
    > Cc: Pawel Moll <pawel.moll@arm.com>
    > Cc: Mark Rutland <mark.rutland@arm.com>
    > Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
    > Cc: Kumar Gala <galak@codeaurora.org>
    >
    > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>

    Looks pretty good, but a few comments.

    > ---
    > .../devicetree/bindings/drm/arm/arm,hdlcd.txt | 74 ++++++++++++++++++++++
    > 1 file changed, 74 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/drm/arm/arm,hdlcd.txt
    >
    > diff --git a/Documentation/devicetree/bindings/drm/arm/arm,hdlcd.txt b/Documentation/devicetree/bindings/drm/arm/arm,hdlcd.txt
    > new file mode 100644
    > index 0000000..b57f1b9
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/drm/arm/arm,hdlcd.txt
    > @@ -0,0 +1,74 @@
    > +ARM HDLCD
    > +
    > +This is a display controller found on several development platforms produced
    > +by ARM Ltd and in more modern of its' Fast Models. The HDLCD is an RGB
    > +streamer that reads the data from a framebuffer and sends it to a single
    > +digital encoder (DVI or HDMI).
    > +
    > +Required properties:
    > + - compatible: "arm,hdlcd"
    Kind of generic. Something more specific please.

    > + - reg: Physical base address and length of the controller's registers.
    > + If a second pair of address and length values is present this specifies
    > + the presence of a DMA coherent memory area that the HDLCD can use as
    > + framebuffer instead of normal CMA memory.

    This is on-chip RAM or nornal system RAM? We already have bindings for
    both.

    > + - interrupts: One interrupt used by the display controller to notify the
    > + interrupt controller when any of the interrupt sources programmed in
    > + the interrupt mask register have activated.
    > + - clocks: A list of phandle + clock-specifier pairs, one for each
    > + entry in 'clock-names'.
    > + - clock-names: A list of clock names. For HDLD it should contain:
    > + - "pxlclk" for the clock feeding the output PLL of the controller.
    > + - port: The HDLCD connection to an encoder chip. The connection is modelled
    > + using the OF graph bindings specified in Documentation/devicetree/bindings/graph.txt.


    \
     
     \ /
      Last update: 2015-11-11 20:01    [W:4.325 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site