lkml.org 
[lkml]   [2015]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] rcu: Clean up TASKS_RCU() abuse
On Wed, Nov 11, 2015 at 02:23:04PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 11, 2015 at 04:49:40AM -0800, Paul E. McKenney wrote:
> > On Wed, Nov 11, 2015 at 01:23:10PM +0100, Peter Zijlstra wrote:
> > > Hi
> > >
> > > I recently ran into TASKS_RCU() and wondered why we can't use normal
> > > coding patterns to do the same.
> > >
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >
> > Well, I cannot get too excited either way, but the diffstat for this
> > change is not particularly favorable.
>
> It also doesn't build with TASKS_RCU enabled it turns out. But the point
> is, nowhere else do we use this pattern. We always provide functions.

RCU_TRACE() another very similar macro, and has been in place for quite
some time. Still within RCU, admittedly, but it does exist.

Thanx, Paul



\
 
 \ /
  Last update: 2015-11-11 15:01    [W:0.042 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site