lkml.org 
[lkml]   [2015]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/20] staging/wilc1000: add struct net_device declaration
Date
On Tuesday 10 November 2015 15:47:02 Joe Perches wrote:
> On Wed, 2015-11-11 at 00:42 +0100, Arnd Bergmann wrote:
> > A recent cleanup added a reference to struct net_device, but
> > that structure is not always visible in the context of the
> > declaration, so we may get a compile-time error:
> >
> > In file included from wilc1000/host_interface.c:5:0:
> > wilc1000/host_interface.h:705:46: warning: 'struct net_device' declared inside parameter list
> > s32 wilc_init(struct net_device *dev, struct host_if_drv **phWFIDrv);
> >
> > This adds a forward-declaration for the structure name to avoid
> > that error.
>
> why not #include <linux/netdevice.h> ?
>

The headers in this driver are still a bit fragile, better not
add in too many other headers, especially before the rest of my
series is applied.

Arnd


\
 
 \ /
  Last update: 2015-11-11 01:21    [W:0.064 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site