Messages in this thread | | | From | Måns Rullgård <> | Subject | Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller | Date | Tue, 10 Nov 2015 20:53:19 +0000 |
| |
David Miller <davem@davemloft.net> writes:
> From: Måns Rullgård <mans@mansr.com> > Date: Tue, 10 Nov 2015 18:05:15 +0000 > >> Because I haven't been following the netdev list closely for the last >> five years, and no documentation I read mentioned this function. I can >> certainly change it. > > It is always advisable to mimick what other drivers do and use them as > a reference, rather than depend upon documentation which by definition > is always going to be out of sync with the source tree.
Sure. The trick is to pick the right driver(s) to use as reference. Quite a few of them don't use that function.
-- Måns Rullgård mans@mansr.com
| |