Messages in this thread | | | Date | Tue, 10 Nov 2015 18:05:15 +0300 | Subject | Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru | From | Dmitry Krivenok <> |
| |
> Is your concern readibility or size of generated code (or both?) > > I'll look to consolidating the debug printing in next version as additional patch.
Just a minor style comment, not critical.
> If we had a longer list, I would definitely say yes. Not so sure with > just two types. I'll take a look for the next version.
The same, just a style comment.
> list_for_each_entry(nvdimm_bus, &nvdimm_bus_list, list) { > - if (nvdimm_bus->id == id) { > + if (nvdimm_bus->id != id)
I noticed another minor issue. You have switched from "==" to "!=" here, but you didn't add "break" after ioctl is handled for the found bus.
Thanks, Dmitry
| |