Messages in this thread | | | From | Peter Maydell <> | Date | Tue, 10 Nov 2015 14:54:13 +0000 | Subject | Re: [PATCH] Documentation: dt: Add bindings for Secure-only devices |
| |
On 10 November 2015 at 14:51, Rob Herring <robh@kernel.org> wrote: > On Fri, Oct 30, 2015 at 08:07:34PM +0000, Peter Maydell wrote: >> + status = "okay"; secure-status = "okay"; // ditto >> + secure-status = "okay"; // ditto >> + // neither explicitly defined: ditto >> >> (Do you want the full set of 9 options you get from multiplying >> out "okay" vs "disabled" vs not-set for each property?) > > Better to err on completeness. The inheritance is easily missed. > > Also, one nit. Use C style comments so when people copy-n-paste this it > is the correct style.
OK; I'll send out a v2 with these fixes.
thanks -- PMM
| |