lkml.org 
[lkml]   [2015]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/rockchip: vop: fix window origin calculation
From
Date
Hi Mark,

On 11/10/2015 05:59 PM, Mark Yao wrote:
> From: Dominik Behr <dbehr@chromium.org>
>
> VOP_WINx_DSP_ST does not require subtracting 1 from the values written to
> it. It actually causes the screen to be shifted by one pixel.
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>

I have meet the screen shift problem on RK3036 SDK board, and this
could fix my problem, so

Tested-by: Yakir Yang <ykk@rock-chips.com>

- Yakir

> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 48719df..4730ae4 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -959,8 +959,8 @@ static int vop_update_plane_event(struct drm_plane *plane,
> val = (dest.y2 - dest.y1 - 1) << 16;
> val |= (dest.x2 - dest.x1 - 1) & 0xffff;
> VOP_WIN_SET(vop, win, dsp_info, val);
> - val = (dsp_sty - 1) << 16;
> - val |= (dsp_stx - 1) & 0xffff;
> + val = dsp_sty << 16;
> + val |= dsp_stx & 0xffff;
> VOP_WIN_SET(vop, win, dsp_st, val);
> VOP_WIN_SET(vop, win, rb_swap, rb_swap);
>




\
 
 \ /
  Last update: 2015-11-10 11:21    [W:0.063 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site