lkml.org 
[lkml]   [2015]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] arm64: Juno: Add support for the PCIe host bridge on Juno R1
On Fri, Oct 09, 2015 at 08:54:33AM -0500, Rob Herring wrote:
> On Fri, Oct 9, 2015 at 8:45 AM, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> > Juno R1 board sports a functional PCIe host bridge that is
> > compliant with the SBSA standard found here[1]. With the right
> > firmware that initialises the XpressRICH3 controller one can
> > use the generic Host Bridge driver to use the PCIe hardware.
> >
> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> >
> > [1] http://infocenter.arm.com/help/topic/com.arm.doc.den0029a/
> > ---
> > arch/arm64/boot/dts/arm/juno-r1.dts | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts
> > index c627511..a702a6b 100644
> > --- a/arch/arm64/boot/dts/arm/juno-r1.dts
> > +++ b/arch/arm64/boot/dts/arm/juno-r1.dts
> > @@ -109,6 +109,26 @@
> >
> > #include "juno-base.dtsi"
> >
> > + pcie-controller@40000000 {
> > + compatible = "pci-host-ecam-generic";
>
> I think this is the first case of real h/w using this. We should have
> a specific compatible here additionally.

Or maybe I can claim the use of the string on account on being the first on arm64 ;)

I can add a vendor prefix if you want, but pci-host-generic is going to ignore it
*because* it is trying to be a generic driver.

> Perhaps the firmware did not setup something correctly.

Hope not :) I no longer have that much input into the UEFI firmware, but for U-Boot is
is all in the open and can be fixed at any time (?).

Thanks for reviewing this!

Best regards,
Liviu

>
> > + device_type = "pci";
> > + reg = <0 0x40000000 0 0x10000000>; /* ECAM config space */
> > + bus-range = <0 255>;
> > + linux,pci-domain = <0>;
> > + #address-cells = <3>;
> > + #size-cells = <2>;
> > + dma-coherent;
> > + ranges = <0x01000000 0x00 0x5f800000 0x00 0x5f800000 0x0 0x00800000
> > + 0x02000000 0x00 0x50000000 0x00 0x50000000 0x0 0x08000000
> > + 0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
> > + #interrupt-cells = <1>;
> > + interrupt-map-mask = <0 0 0 7>;
> > + interrupt-map = <0 0 0 1 &gic 0 0 0 136 4
> > + 0 0 0 2 &gic 0 0 0 137 4
> > + 0 0 0 3 &gic 0 0 0 138 4
> > + 0 0 0 4 &gic 0 0 0 139 4>;
> > + msi-parent = <&v2m_0>;
> > + };
> > };
> >
> > &memtimer {
> > --
> > 2.6.0
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯


\
 
 \ /
  Last update: 2015-10-09 16:21    [W:0.091 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site