lkml.org 
[lkml]   [2015]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: error: implicit declaration of function 'zero_bytemask'
From
Date


On 7. října 2015 15:29:28 CEST, Chris Metcalf <cmetcalf@ezchip.com> wrote:
>On 10/07/2015 08:53 AM, Michal Sojka wrote:
>> Dear Chris,
>>
>> the following commit breaks my Linux build.
>>
>> commit 990486c8af044f89bddfbde1d1cf9fde449bedbf
>> Author: Chris Metcalf <cmetcalf@ezchip.com>
>> Date: Tue Oct 6 12:37:41 2015 -0400
>>
>> strscpy: zero any trailing garbage bytes in the destination
>>
>> It's possible that the destination can be shadowed in
>userspace
>> (as, for example, the perf buffers are now). So we should
>take
>> care not to leak data that could be inspected by userspace.
>>
>> The error message is:
>>
>> lib/string.c: In function 'strscpy':
>> lib/string.c:209:4: error: implicit declaration of function
>'zero_bytemask' [-Werror=implicit-function-declaration]
>> cc1: some warnings being treated as errors
>>
>> I compile the kernel for PowerPC (32 bit) with the attached config.
>
>Ah, it appears that big-endian powerpc does not provide
>zero_bytemask(), only little-endian. I'll fix this in v3 of
>the patch series - thanks!

The patch is already in mainline so I guess a fixup patch would be more appropriate.

--
Odesláno z mého telefonu pomocí Kaiten Mail. Omluvte prosím mou stručnost.


\
 
 \ /
  Last update: 2015-10-07 16:01    [W:0.089 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site