Messages in this thread | | | Subject | Re: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable | From | Maurizio Lombardi <> | Date | Wed, 7 Oct 2015 15:28:35 +0200 |
| |
Hi,
On 10/07/2015 03:11 PM, Arnd Bergmann wrote: > - memset(&npiv_tbl, 0, sizeof(npiv_tbl)); > - if (hba->cnic->get_fc_npiv_tbl(hba->cnic, &npiv_tbl)) > + npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL); > + if (!npiv_tbl) > goto done; >
If kzalloc() fails perhaps the function should return -ENOMEM, not zero.
Regards, Maurizio Lombardi
| |