Messages in this thread | | | Date | Tue, 6 Oct 2015 09:34:47 +0200 | From | Francois Romieu <> | Subject | Re: [PATCH] via-rhine: fix VLAN receive handling error in 4.2.x |
| |
Andrej Ota <andrej@ota.si> : > Fixes commit 810f19bcb862 ("via-rhine: add consistent memory barrier in > vlan receive code.") which broke VLAN tag parsing on receive. > > Because eth_type_trans() consumes ethernet header worth of bytes, a call > to read TCI from packet using rhine_rx_vlan_tag() no longer works as it's > reading from an invalid offset. > > Tested to be working on PCEngines Alix board. > > Fixes: 810f19bcb862 ("via-rhine: add consistent memory barrier in vlan receive code.") > Signed-off-by: Andrej Ota <andrej@ota.si>
Minor nits: - Ethernet driver patches should usually be sent to netdev@vger.kernel.org. Their state is thus tracked at http://patchwork.ozlabs.org/project/netdev/list/
- The more specific about the target branch, the better: [PATCH net 1/1] via-rhine: blah -> patch against davem's bugfixes branch [PATCH net-next 19/73] foo: more balh -> patch against davem's dev branch
- davem will take care of -stable propagation
-- Ueimor
| |