lkml.org 
[lkml]   [2015]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 13/25] powerpc/8xx: also use r3 in the ITLB miss in all situations
From
Date
On Tue, 2015-10-06 at 16:12 +0200, Christophe Leroy wrote:
> Le 29/09/2015 02:00, Scott Wood a écrit :
> > On Tue, Sep 22, 2015 at 06:50:54PM +0200, Christophe Leroy wrote:
> > > We are spending between 40 and 160 cycles with a mean of 65 cycles
> > > in the TLB handling routines (measured with mftbl) so make it more
> > > simple althought it adds one instruction
> > >
> > > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > > ---
> > > No change in v2
> > >
> > > arch/powerpc/kernel/head_8xx.S | 15 ++++-----------
> > > 1 file changed, 4 insertions(+), 11 deletions(-)
> > Why is this a separate patch from 1/25?
> >
> > Same comments as on that patch.
> >
> >
> Just because here there is no real need behind the simplification of the
> code, whereas the first one was a pre-requisite for the following patch.
> Should I merge them together anyway ?

If there's no real need, why do it? It's not really a major readability
enhancement...

-Scott



\
 
 \ /
  Last update: 2015-10-06 19:21    [W:0.075 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site