Messages in this thread | | | From | Rasmus Villemoes <> | Subject | Re: [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k | Date | Tue, 06 Oct 2015 17:31:29 +0200 |
| |
On Mon, Oct 05 2015, Bart Van Assche <bart.vanassche@sandisk.com> wrote:
> On 10/05/15 02:26, Rasmus Villemoes wrote: >> struct error_info { >> unsigned short code12; /* 0x0302 looks better than 0x03,0x02 */ >> - const char * text; >> + unsigned short size; >> }; > > Had you considered to use the type uint16_t instead of unsigned short ? >
Yes, but I thought I'd keep it consistent with the other member. AFAIK, they're one and the same on all relevant arches. I actually think spelling it u16 for both members would make sense (for the code because it explicitly is meant to hold two bytes), but again I think that's better done as a trivial follow-up patch, if we really want to change this.
Rasmus
| |