lkml.org 
[lkml]   [2015]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k
    Date
    On Mon, Oct 05 2015, Bart Van Assche <bart.vanassche@sandisk.com> wrote:

    > On 10/05/15 02:26, Rasmus Villemoes wrote:
    >> struct error_info {
    >> unsigned short code12; /* 0x0302 looks better than 0x03,0x02 */
    >> - const char * text;
    >> + unsigned short size;
    >> };
    >
    > Had you considered to use the type uint16_t instead of unsigned short ?
    >

    Yes, but I thought I'd keep it consistent with the other member. AFAIK,
    they're one and the same on all relevant arches. I actually think
    spelling it u16 for both members would make sense (for the code because
    it explicitly is meant to hold two bytes), but again I think that's
    better done as a trivial follow-up patch, if we really want to change this.

    Rasmus


    \
     
     \ /
      Last update: 2015-10-06 18:01    [W:3.139 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site