Messages in this thread Patch in this message | | | From | Jiri Olsa <> | Subject | [PATCH 1/3] perf tools: Get rid of superfluos call to reset_dimensions | Date | Tue, 6 Oct 2015 14:25:10 +0200 |
| |
There's no need to call reset_dimensions within __setup_output_field function. It's already called in its caller setup_sorting right before perf_hpp__init, which will be changed in following patch to respect taken dimension.
Link: http://lkml.kernel.org/n/tip-08mxvkxtuxbboog1exjok9gd@git.kernel.org Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- tools/perf/util/sort.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index ee94b728fca4..8521e3c89b8d 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -1917,8 +1917,6 @@ static int __setup_output_field(void) if (field_order == NULL) return 0; - reset_dimensions(); - strp = str = strdup(field_order); if (str == NULL) { error("Not enough memory to setup output fields"); -- 2.4.3
| |